In diabetes mellitus, the deficiency of trace elements is said to be linked to poor glycemic control and oxidative stress related complications. The deficiency of magnesium and zinc accelerate the disease and its complications. Our study assessed the correlation of serum magnesium and zinc levels with glycemic control in type 2 diabetes patients. Methods: This cross sectional study included 150 study participants. 76 type 2 diabetes patients were cases and 74 healthy participants were grouped to controls. Samples for fasting and postprandial blood glucose, HbA1c, magnesium and zinc were collected and analysed in a fully automated analyser. Data was analysed by Graph Pad Prism software. Results: Cases had higher levels of fasting, postprandial, HbA1c levels as compared to controls with p<0.0001. Cases had significant reduction in serum levels of zinc and magnesium. Zinc and magnesium showed a significant inverse correlation with glycemic control with r values of -0.56 and -0.48 respectively. Conclusion: Low serum magnesium and zinc levels can worsen the complications of disease. So, early detection of its deficiency and supplementation alleviates the disease progression.